8000 [FrameworkBundle] integrate the Cache component by nicolas-grekas · Pull Request #18371 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] integrate the Cache component #18371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 7, 2016
Merged

[FrameworkBundle] integrate the Cache component #18371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc51fde
[Cache] Normalize constructor arguments order
nicolas-grekas Apr 1, 2016
281eafa
[FrameworkBundle] Integrate the Cache component
xabbuh Feb 20, 2016
e44bfdc
[FrameworkBundle] Add cache-pool tag and wiring
nicolas-grekas Mar 4, 2016
92b1a20
[FrameworkBundle] Fix and add tests for cache pool wiring
xabbuh Mar 11, 2016
4740c5c
[FrameworkBundle] use abstract cache.pool decoration and aliases
nicolas-grekas Mar 14, 2016
714b916
[FrameworkBundle] Add & use Psr6CacheClearer
nicolas-grekas Apr 4, 2016
4152634
[FrameworkBundle] Add default pool & system adapter
nicolas-grekas Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Cache] Normalize constructor arguments order
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Apr 4, 2016
commit bc51fdeec365fecf24b50c41598e64199de0d5df
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/DoctrineAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class DoctrineAdapter extends AbstractAdapter
{
private $provider;

public function __construct(CacheProvider $provider, $defaultLifetime = 0, $namespace = '')
public function __construct(CacheProvider $provider, $namespace = '', $defaultLifetime = 0)
{
parent::__construct('', $defaultLifetime);
$this->provider = $provider;
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/FilesystemAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class FilesystemAdapter extends AbstractAdapter
{
private $directory;

public function __construct($directory, $defaultLifetime = 0, $namespace = '')
public function __construct($namespace = '', $defaultLifetime = 0, $directory = null)
{
parent::__construct('', $defaultLifetime);

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/ProxyAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ProxyAdapter implements AdapterInterface
private $hits = 0;
private $misses = 0;

public function __construct(CacheItemPoolInterface $pool, $defaultLifetime = 0, $namespace = '')
public function __construct(CacheItemPoolInterface $pool, $namespace = '', $defaultLifetime = 0)
{
$this->pool = $pool;
$this->namespace = $this->getId($namespace, true);
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Tests/Adapter/ChainAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function createCachePool()
$this->skippedTests['testDeferredSaveWithoutCommit'] = 'Fails on HHVM';
}

return new ChainAdapter(array(new ArrayAdapter(), new ExternalAdapter(), new FilesystemAdapter(null)));
return new ChainAdapter(array(new ArrayAdapter(), new ExternalAdapter(), new FilesystemAdapter()));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Tests/Adapter/NamespacedProxyAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ class NamespacedProxyAdapterTest extends ProxyAdapterTest
{
public function createCachePool()
{
return new ProxyAdapter(new ArrayAdapter(), 0, 'foo');
return new ProxyAdapter(new ArrayAdapter(), 'foo');
}
}
0