10000 Fixed the styles of the Symfony icon in the web debug toolbar by javiereguiluz · Pull Request #18347 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fixed the styles of the Symfony icon in the web debug toolbar #18347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

javiereguiluz
Copy link
Member
Q A
Branch? 2.8+
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Before

symfony_icon_before

After

symfony_icon_after


@WhiteEagle88 the change from 24 to 40 was made in this commit of yours to fix some problems with Microsoft Edge browser. Could you please check if this pull request breaks anything for you? Thanks!

@fabpot
Copy link
Member
fabpot commented Mar 31, 2016

Thank you @javiereguiluz.

@fabpot fabpot merged commit ddc8d4e into symfony:2.8 Mar 31, 2016
fabpot added a commit that referenced this pull request Mar 31, 2016
…bar (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Fixed the styles of the Symfony icon in the web debug toolbar

| Q             | A
| ------------- | ---
| Branch?       | 2.8+
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Before

![symfony_icon_before](https://cloud.githubusercontent.com/assets/73419/14114615/d63240fc-f5d7-11e5-9cd2-b0a67077dbe7.png)

### After

![symfony_icon_after](https://cloud.githubusercontent.com/assets/73419/14114617/d95e7cc8-f5d7-11e5-8ff3-6e706b8c5de8.png)

---

@WhiteEagle88 the change from `24` to `40` was made in [this commit](d120c08) of yours to fix some problems with Microsoft Edge browser. Could you please check if this pull request breaks anything for you? Thanks!

Commits
-------

ddc8d4e Fixed the styles of the Symfony icon in the web debug toolbar
This was referenced Apr 29, 2016
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
…ug toolbar (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Fixed the styles of the Symfony icon in the web debug toolbar

| Q             | A
| ------------- | ---
| Branch?       | 2.8+
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Before

![symfony_icon_before](https://cloud.githubusercontent.com/assets/73419/14114615/d63240fc-f5d7-11e5-9cd2-b0a67077dbe7.png)

### After

![symfony_icon_after](https://cloud.githubusercontent.com/assets/73419/14114617/d95e7cc8-f5d7-11e5-8ff3-6e706b8c5de8.png)

---

@WhiteEagle88 the change from `24` to `40` was made in [this commit](symfony@d120c08) of yours to fix some problems with Microsoft Edge browser. Could you please check if this pull request breaks anything for you? Thanks!

Commits
-------

ddc8d4e Fixed the styles of the Symfony icon in the web debug toolbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0