8000 [TwigBridge] fix lowest required Form dependency by xabbuh · Pull Request #18335 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] fix lowest required Form dependency #18335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2016
Merged

[TwigBridge] fix lowest required Form dependency #18335

merged 1 commit into from
Mar 28, 2016

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 28, 2016
Q A
Branch? 3.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added the Ready label Mar 28, 2016
@fabpot
Copy link
Member
fabpot commented Mar 28, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit 77139ca into symfony:3.0 Mar 28, 2016
fabpot added a commit that referenced this pull request Mar 28, 2016
@fabpot
minor #18335 [TwigBridge] fix lowest required Form dependency (xabbuh)
27dc53e 
This PR was merged into the 3.0 branch.

Discussion
----------

[TwigBridge] fix lowest required Form dependency

| Q             | A
| ------------- | ---
| Branch?       | 3.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

77139ca [TwigBridge] fix lowest required Form dependency
@xabbuh xabbuh deleted the pr-18275 branch March 28, 2016 07:12
Tobion
Tobion reviewed Jun 15, 2016
View reviewed changes
src/Symfony/Bridge/Twig/composer.json
@@ -22,7 +22,7 @@
"require-dev": {
"symfony/asset": "~2.8|~3.0",
"symfony/finder": "~2.8|~3.0",
"symfony/form": "~2.8.4|~3.0.4",
"symfony/form": "~3.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that form 3.1 is not allowed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @Tobion @carsonbot
0