8000 [Security][CSRF] Double Submit Cookies CSRF prevention strategy by backbone87 · Pull Request #18333 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security][CSRF] Double Submit Cookies CSRF prevention strategy #18333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[Security][CSRF] Double Submit Cookies CSRF prevention strategy #18333

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d746f31
extend csrf token storage infrastructure
backbone87 Mar 28, 2016
e9573af
code style and feedback
backbone87 Sep 21, 2016
beed130
more codestyle fixes
backbone87 Sep 21, 2016
1cea0d2
remove @see
backbone87 Sep 21, 2016
a298be6
update suggestion notice in composer.json
backbone87 Sep 21, 2016
a533b0e
add a secureNamespace to SessionTokenStorageFactory for secure requests
backbone87 Sep 21, 2016
893fa0c
implement EventSubscriberInterface into CookieTokenStorageListener
backbone87 Sep 24, 2016
61b5483
add verification logic to CookieTokenStorage
backbone87 Sep 25, 2016
6e19ef9
rework CookieTokenStorage
backbone87 Sep 26, 2016
99dde3b
code style
backbone87 Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a secureNamespace to SessionTokenStorageFactory for secure requests
  • Loading branch information
@backbone87
backbone87 committed Sep 21, 2016
commit a533b0e45e0a7e0573f4d72978adb692be7d448d
15 changes: 12 additions & 3 deletions src/Symfony/Component/Security/Csrf/TokenStorage/SessionTokenStorageFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,18 @@ class SessionTokenStorageFactory implements TokenStorageFactoryInterface
private $namespace;

/**
* @param string $namespace The namespace under which the token is stored in the session
* @var string
*/
public function __construct($namespace = null)
private $secureNamespace;

/**
* @param string $namespace The namespace under which tokens are stored in the session
* @param string $secureNamespace The namespace under which tokens are stored in the session for secure connections
*/
public function __construct($namespace = null, $secureNamespace = null)
{
$this->namespace = $namespace === null ? SessionTokenStorage::SESSION_NAMESPACE : (string) $namespace;
$this->secureNamespace = $secureNamespace === null ? $this->namespace : (string) $secureNamespace;
}

/**
Expand All @@ -44,6 +51,8 @@ public function createTokenStorage(Request $request)
throw new RuntimeException('Request has no session');
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could modify the namespace here, to use a different one for SSL connections, because tokens transmitted via non SSL connections are subject to MITM attacks.

return new SessionTokenStorage($session, $this->namespace);
$namespace = $request->isSecure() ? $this->secureNamespace : $this->namespace;

return new SessionTokenStorage($session, $namespace);
}
}
0