8000 [DomCrawler] Attach label to form fields by carlosV2 · Pull Request #18322 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DomCrawler] Attach label to form fields #18322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggested patches
  • Loading branch information
Carlos Ortega Huetos committed Mar 26, 2016
commit 081314cd7c1e3b8de50ed9e5981f55de54588eaa
2 changes: 1 addition & 1 deletion src/Symfony/Component/DomCrawler/Field/FormField.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function __construct(\DOMElement $node, \DOMElement $label = null)
}

/**
* Returns the label tag associated to the field or null if none
* Returns the label tag associated to the field or null if none.
*
* @return \DOMElement|null
*/
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/DomCrawler/Form.php
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ private function addField(\DOMElement $node)
}

/**
* Finds the associated label to a given field node
* Finds the associated label to a given field node.
*
* @param \DOMElement $node The \DOMElement instance of the field
*
Expand All @@ -497,6 +497,6 @@ private function findAssociatedLabel(\DOMElement $node)
}
}

return null;
return;
}
}
0