8000 [FrameworkBundle 2.7+] Removed unused variables by linaori · Pull Request #18293 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle 2.7+] Removed unused variables #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016
Merged

[FrameworkBundle 2.7+] Removed unused variables #18293

merged 1 commit into from
Mar 24, 2016

Conversation

linaori
Copy link
Contributor
@linaori linaori commented Mar 24, 2016
Q A
Branch? 2.7, can be merged upwards
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

I noticed some unused variables in the Framework Extension. I did a project inspection in phpstorm and I found nothing else. Hence I submit this PR to make it consistent again.

@Tobion
Copy link
Contributor
Tobion commented Mar 24, 2016

Thank you @iltar.

@Tobion Tobion merged commit 9fea1ee into symfony:2.7 Mar 24, 2016
Tobion added a commit that referenced this pull request Mar 24, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle 2.7+] Removed unused variables

| Q             | A
| ------------- | ---
| Branch?       | 2.7, can be merged upwards
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

I noticed some unused variables in the Framework Extension. I did a project inspection in phpstorm and I found nothing else. Hence I submit this PR to make it consistent again.

Commits
-------

9fea1ee Removed unused variables
@linaori linaori deleted the cleanup/unused-variables-27 branch April 15, 2016 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0