fix controller tests #18282
Merged
fix controller tests #18282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we actually need to do some of these fixes in the |
|
see #18283 |
|
failures on AppVeyor are not related |
|
👍 thanks for fixing this @xabbuh! |
6ac0be8 to
12c0ac2
Compare
Add missing public method stubs to `TestController` (all methods in the base `Controller` class from the FrameworkBundle are `protected` since Symfony 3.0).
12c0ac2 to
fb963d2
Compare
xabbuh
added a commit
that referenced
this pull request
Mar 23, 2016
This PR was merged into the 3.0 branch. Discussion ---------- fix controller tests | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | items 9 to 12 from sebastianbergmann/phpunit-mock-objects#299 (comment) | License | MIT | Doc PR | Add missing public method stubs to `TestController` (all methods in the base `Controller` class from the FrameworkBundle are `protected` since Symfony 3.0). Commits ------- fb963d2 fix controller tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing public method stubs to
TestController(all methods in the baseControllerclass from the FrameworkBundle areprotectedsince Symfony 3.0).