8000 use class constants instead of FQCN strings by xabbuh · Pull Request #18278 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

use class constants instead of FQCN strings #18278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2016
Merged

use class constants instead of FQCN strings #18278

merged 1 commit into from
Mar 23, 2016

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 23, 2016
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18211 (comment)
License MIT
Doc PR

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit d4ec7dd into symfony:master Mar 23, 2016
nicolas-grekas added a commit that referenced this pull request Mar 23, 2016
@nicolas-grekas
minor #18278 use class constants instead of FQCN strings (xabbuh)
c7493f5 
This PR was merged into the 3.1-dev branch.

Discussion
----------

use class constants instead of FQCN strings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18211 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

d4ec7dd use class constants instead of FQCN strings
@xabbuh xabbuh deleted the pr-18211 branch March 23, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot
0