10000 [Console] use the clock mock for progress indicator tests by xabbuh · Pull Request #18213 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Console] use the clock mock for progress indicator tests #18213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 17, 2016
Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18200
License MIT
Doc PR

Unfortunately, I opened #18200 for the wrong branch.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 584b752 into symfony:2.8 Mar 17, 2016
nicolas-grekas added a commit that referenced this pull request Mar 17, 2016
…s (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Console] use the clock mock for progress indicator tests

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18200
| License       | MIT
| Doc PR        |

Unfortunately, I opened #18200 for the wrong branch.

Commits
-------

584b752 use the clock mock for progress indicator tests
@xabbuh xabbuh deleted the backport-progress-indicator-clock-mock-tests branch March 17, 2016 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0