[travis] Run real php subprocesses on hhvm for Process component tests #18194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And the answer is... YES, by one minute! |
|
Great! Thanks for your continuous effort towards optimizing tests. This is much appreciated by lots of us! |
|
@nicolas-grekas there is a failed test and marked as pass : https://travis-ci.org/symfony/symfony/jobs/116377636#L4679 |
|
@Prophet777 this is hhvm behavior, nothing related to this PR, and no failure but only garbage output. |
|
Ok great, that was just in case! Thank you |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 16, 2016
…omponent tests (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [travis] Run real php subprocesses on hhvm for Process component tests | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Let's see if this speeds up hhvm test matrix line. Commits ------- c722e35 [travis] Run real php subprocesses on hhvm for Process component tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this speeds up hhvm test matrix line.