8000 [DI] Only rebuild autowiring cache when actually needed by weaverryan · Pull Request #18144 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Only rebuild autowiring cache when actually needed #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[DI] Only rebuild autowiring cache when actually needed #18144

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0b600a
Smart caching system for autowiring to only clear container cache whe…
weaverryan Mar 12, 2016
c706c04
Fixes thanks to Stof
weaverryan Mar 29, 2016
011e203
Implementing a method on symfony/config 2.8's ResourceInterface for 2…
weaverryan Mar 29, 2016
49271e8
Coding standards changes - via fabpot
weaverryan Apr 1, 2016
56b4bf9
Trying to get more fine-grained over the actual information we need
weaverryan Apr 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to 8000
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Trying to get more fine-grained over the actual information we need
  • Loading branch information
@weaverryan
weaverryan committed Apr 1, 2016
commit 56b4bf9f1f11f2ab45fb4b6c0b4852fa2bd1b7fb
13 changes: 12 additions & 1 deletion src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,18 @@ static private function getResourceMetadataForMethod(\ReflectionMethod $method)
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Avoid excessively long variable names like $methodArgumentsMetadata. Keep variable name length under 20.

$methodArgumentsMetadata = array();
foreach ($method->getParameters() as $parameter) {
$methodArgumentsMetadata[] = (string) $parameter;
try {
$class = $parameter->getClass();
} catch (\ReflectionException $e) {
// type-hint is against a non-existent class
$class = false;
}

$methodArgumentsMetadata[] = array(
'class' => $class,
'isOptional' => $parameter->isOptional(),
'defaultValue' => $parameter->isOptional() ? $parameter->getDefaultValue() : null,
);
}

return $methodArgumentsMetadata;
Expand Down
0