8000 [HttpFoundation] fix comments Issue for newcomers (3) [Hack Day] by MGDSoft · Pull Request #18127 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpFoundation] fix comments Issue for newcomers (3) [Hack Day] #18127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] fix comments Issue for newcomers (3) [Hack Day] #18127

wants to merge 1 commit into from

Conversation

MGDSoft
Copy link
Contributor
@MGDSoft MGDSoft commented Mar 12, 2016
Q A
Branch 2.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #18090
License MIT
Doc PR

fix comments in src/Symfony/Component/HttpFoundation/Session/Storage/SessionStorageInterface.php

fix comments in src/Symfony/Component/HttpFoundation/Session/Storage/SessionStorageInterface.php
@javiereguiluz
Copy link
Member

@MGDSoft thanks for this contribution! You did it great: the fixed "code", the pull request description, the branch name (ticket_18090), etc.

@javiereguiluz
Copy link
Member

A note to you from Symfony maintainers:

Thank you for making this contribution to Symfony. As you know, we prepared some simple issues so you could submit real pull requests fixing real issues. However, as there are more people than issues, we'll need to close some repeated pull requests without merging them.

We are not sure about the criteria we'll use to close repeated pull requests (first one wins? randomly selected one wins?). So maybe your pull request is closed without merging it. But please, don't feel bad about that. You did great and you actually contributed to Symfony 🎉 If this pull request doesn't get merged, there will be more opportunities to send new pull requests.

Thank you for being part of the (big and awesome) Symfony Community!

@fabpot fabpot closed this Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0