[SecurityBundle][PHPDoc] Added method doumentation for SecurityFactor… #18114
Conversation
| Q | A |
|---|---|
| Branch | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10870 |
| License | MIT |
| Doc PR |
| * Defines the configuration key used to reference the provider | ||
| * in the firewall configuration. | ||
| * | ||
| * @return string |
There was a problem hiding this comment.
Can you verify if it's really just the key or if it's the context? The context is the option you can pass along to a firewall in case they share they share context but have a different name. By default the context (if not provided) is the firewall name.
There was a problem hiding this comment.
@iltar this is not the key or context of a firewall, it's just the name of the node in the configuration: https://github.com/symfony/security-bundle/blob/7f04a9ae1ff1dd4eeb6ad20b5df48fdd9c2230e3/DependencyInjection/MainConfiguration.php#L285
There was a problem hiding this comment.
Ah, got me really confused there, I'd expect something like authenticator name or similar :)
You can ignore my comment
|
Thank you @aminemat. |
…ecurityFactor… (aminemat) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18114). Discussion ---------- [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactor… | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10870 | License | MIT | Doc PR | Commits ------- cfb3ea1 [SecurityBundle][PHPDoc] Added method doumentation for SecurityFactoryInterface