[WebProfilerBundle] fix context log pre wrap #18059
Conversation
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
|
On very long context it is impossible to read or scroll the log. I don't know if it's the best way to handle it though. Before: After: |
|
I'm 👍 for the change. Thanks @HeahDude. But I have a question: why don't you see the log contents in several lines? This is how I see this:
|
|
I guess because it's an array with a single |
|
No, in fact I don't know :) |
|
Ok I think I found it, working on a patch ;) |
|
I pushed a second commit 209c819 which fixes it, now looks like: |
|
Thanks for working on this. However, I'm not sure about the second commit. The |
|
@javiereguiluz sure, I understand. Still, if this class is meant to ease reading while debugging, it may help to not inline arrays just because they don't have nested arrays, my captures are good example. Let me know if I should keep it like this, discard or squash this commit. Thanks. |
209c819 to
1be25ab
Compare
|
The ValueExporter class is only used for the profiler, so I think it won't break anything. You can probably browse all the tabs from a profile to confirm that it works well everywhere. |
|
Thanks, I can confirm. If I'm not wrong my commit only increase readability for inline arrays. |
|
Thank you @HeahDude. |
…hDude) This PR was squashed before being merged into the 3.1-dev branch (closes symfony#18059). Discussion ---------- [WebProfilerBundle] fix context log pre wrap | Q | A | ------------- | --- | Branch | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 6b23861 [WebProfilerBundle] fix context log pre wrap