8000 fix lowest TwigBridge deps versions by xabbuh · Pull Request #18037 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

fix lowest TwigBridge deps versions #18037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2016
Merged

fix lowest TwigBridge deps versions #18037

merged 1 commit into from
Mar 7, 2016

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 6, 2016
Q A
Branch 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17568
License MIT
Doc PR

This is necessary as #17568 was neither part of 2.7.10 nor 2.8.3.

HeahDude
HeahDude reviewed Mar 6, 2016
View reviewed changes
src/Symfony/Bridge/Twig/composer.json
@@ -22,7 +22,7 @@
"require-dev": {
"symfony/asset": "~2.7",
"symfony/finder": "~2.3",
"symfony/form": "~2.7.10|~2.8.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ~2.7|~2.8 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow, for example, 2.7.0 and 2.8.0 which would be used when running the CI job with deps=low which would then fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks!

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 526376f into symfony:2.7 Mar 7, 2016
nicolas-grekas added a commit that referenced this pull request Mar 7, 2016
@nicolas-grekas
minor #18037 fix lowest TwigBridge deps versions (xabbuh)
a1dc071 
This PR was merged into the 2.7 branch.

Discussion
----------

fix lowest TwigBridge deps versions

| Q             | A
| ------------- | ---
| Branch        | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17568
| License       | MIT
| Doc PR        |

This is necessary as #17568 was neither part of 2.7.10 nor 2.8.3.

Commits
-------

526376f fix lowest TwigBridge deps versions
@xabbuh xabbuh deleted the twig-bridge-lowest-form-deps branch March 7, 2016 12:54
@HeahDude HeahDude mentioned this pull request Mar 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review TwigBridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @HeahDude @javiereguiluz @carsonbot
0