[FrameworkBundle] Deprecate absolute template paths #18034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #17999 |
| License | MIT |
| Doc PR | - |
| $isAbsolute = (bool) preg_match('#^(?:/|[a-zA-Z]:)#', $file); | ||
|
|
||
| if ($isAbsolute) { | ||
| @trigger_error('Absolute template path support is deprecated since Symfony 3.1 and will throw an exception in 4.0.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
Instead of:
... and will throw an exception in 4.0
I think we usually write it like this:
... and it will be removed in 4.0
274cd46 to
6bb73ae
Compare
|
|
||
| * As it was never an officially supported feature, | ||
| the support for absolute template paths has been deprecated | ||
| and will be removed in Symfony 4.0. |
There was a problem hiding this comment.
The positions of the line breaks look a bit weird.
|
👍 |
| set_error_handler(function ($type, $msg) use (&$deprecations) { | ||
| if (E_USER_DEPRECATED === $type) { | ||
| $deprecations[] = $msg; | ||
| } |
There was a problem hiding this comment.
just for safety, maybe we should do something in the "else" case? like forwarding to the previous error handler?
There was a problem hiding this comment.
Sure. To be honest I copied this one from other test. Perhaps we should fix in in all ocurences? I won't be able to look into this before evening today.
There was a problem hiding this comment.
@nicolas-grekas is throwing an exception like I did just now acceptable?
6bb73ae to
85a9d67
Compare
|
👍 (failures unrelated) |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Mar 15, 2016
…akzal) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Deprecate absolute template paths | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #17999 | License | MIT | Doc PR | - Commits ------- 85a9d67 [FrameworkBundle] Deprecate absolute template paths
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.