8000 [HttpFoundation] Fix the build on windows (with mbstring extension missing) by jakzal · Pull Request #18029 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fix the build on windows (with mbstring extension missing) #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[HttpFoundation] Fix the build on windows (with mbstring extension missing) #18029

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2257aa
[HttpFoundation] Fix the build on windows (with mbstring extension mi…
jakzal Mar 6, 2016
0b01fb1
[HttpFoundation] Fix the test on windows
jakzal Mar 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[HttpFoundation] Fix the test on windows 
A file with non-ascii characters in the name needs to be created from PHP
in order for it to be read properly on all platforms.
  • Loading branch information
@jakzal
jakzal committed Mar 6, 2016
commit 0b01fb1f1dbef6e7ef9e4a8c67169d30b78bb2e9
8 changes: 7 additions & 1 deletion src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ public function testConstruction()

public function testConstructWithNonAsciiFilename()
{
new BinaryFileResponse(__DIR__.'/Fixtures/föö.html', 200, array(), true, 'attachment');
touch(sys_get_temp_dir().'/fööö.html');

$response = new BinaryFileResponse(sys_get_temp_dir().'/fööö.html', 200, array(), true, 'attachment');

$this->assertSame('fööö.html', $response->getFile()->getFilename());

@unlink(sys_get_temp_dir().'/fööö.html');
}

/**
Expand Down
0