8000 Added pipe for multiline string (correctly indented), which makes them much more readable by mercmobily · Pull Request #17912 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Added pipe for multiline string (correctly indented), which makes them much more readable #17912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Added pipe for multiline string (correctly indented), which makes them much more readable #17912

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d3b1fa
Multiline strings handled with correct tabs
mercmobily Feb 24, 2016
dfb21a6
Missing semicolon added
mercmobily Feb 24, 2016
db84e15
Coding standard
mercmobily Feb 24, 2016
2de3aee
More coding tandards
mercmobily Feb 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missing semicolon added
  • Loading branch information
@mercmobily
mercmobily committed Feb 24, 2016
commit dfb21a672a26447446c25e4082a1b17699ea1f34
2 changes: 1 addition & 1 deletion src/Symfony/Component/Yaml/Yaml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public static function parse($input, $flags = 0)
*
* @return string A YAML string representing the original PHP array
*/
public static function dump($array, $inline = 2, $indent = 4, $absInden = 0,$flags = 0)
public static function dump($array, $inline = 2, $indent = 4, $absIndent = 0,$flags = 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to expose it to the outside here ? This makes the signature harder to use and understand (and a pain for backward compatibility).

Btw, the fact that you are adding the argument before an existing one breaks all usages of the flags.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I don't know php.... How do I carry that value over without passing it as
argument in recursion?

An hint will suffice!

Will write tests once you approve at least what I am doing...

Merc.
On 24 Feb 2016 6:20 pm, "Christophe Coevoet" notifications@github.com
wrote:

In src/Symfony/Component/Yaml/Yaml.php
#17912 (comment):

@@ -89,7 +90,7 @@ public static function parse($input, $flags = 0)
*
* @return string A YAML string representing the original PHP array
*/

  • public static function dump($array, $inline = 2, $indent = 4, $flags = 0)
  • public static function dump($array, $inline = 2, $indent = 4, $absIndent = 0,$flags = 0)

Do we actually need to expose it to the outside here ? This makes the
signature harder to use and understand (and a pain for backward
compatibility).

Btw, the fact that you are adding the argument before an existing one
breaks all usages of the flags.

—
Reply to this email directly or view it on GitHub
https://github.com/symfony/symfony/pull/17912/files#r53918375.

{
if (is_bool($flags)) {
@trigger_error('Passing a boolean flag to toggle exception handling is deprecated since version 3.1 and will be removed in 4.0. Use the DUMP_EXCEPTION_ON_INVALID_TYPE flag instead.', E_USER_DEPRECATED);
Expand Down
0