10000 [Ldap] Add write support for the Ldap component by csarrazi · Pull Request #17817 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Ldap] Add write support for the Ldap component #17817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2016
Merged

[Ldap] Add write support for the Ldap component #17817

merged 1 commit into from
Feb 18, 2016

Conversation

csarrazi
Copy link
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #17679
License MIT
Doc PR no

This PR implements write support for the Ldap component.

@fabpot
Copy link
Member
fabpot commented Feb 17, 2016

@csarrazi Can you submit a different PR for the fixes of #16665? As those changes are non-controversial, we can merge them much faster and it won't "pollute" the new feature added here.

@csarrazi
Copy link
Contributor Author

No problem. I'll patch-commit things, and submit 2 PRs.

@csarrazi csarrazi changed the title [Ldap] [WIP] Add write support for the Ldap component [Ldap] Add write support for the Ldap component Feb 17, 2016
@csarrazi
Copy link
Contributor Author

Done. Ping @fabpot

@fabpot
Copy link
Member
fabpot commented Feb 18, 2016

👍

@fabpot
Copy link
Member
fabpot commented Feb 18, 2016

Thank you @csarrazi.

@fabpot fabpot merged commit dfd04ff into symfony:master Feb 18, 2016
fabpot added a commit that referenced this pull request Feb 18, 2016
…azi)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[Ldap] Add write support for the Ldap component

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17679
| License       | MIT
| Doc PR        | no

This PR implements write support for the Ldap component.

Commits
-------

dfd04ff Added support for adding / removing / updating Ldap entries
@L0rD59
Copy link
L0rD59 commented Feb 18, 2016

👍

/**
* Sets a value for the given attribute.
*
* @param $name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing type

@csarrazi csarrazi deleted the feature/add-remove-entry branch February 18, 2016 12:53
fabpot added a commit that referenced this pull request Feb 20, 2016
… (csarrazi)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[Ldap] Fixed PHPDoc for the Ldap component's Entry class

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Fixes the remaining comments from PR #17817

Commits
-------

a93ce04 Fixed PHPDoc for the Ldap component's Entry class
@fabpot fabpot mentioned this pull request May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0