-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Ldap] Add write support for the Ldap component #17817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No problem. I'll patch-commit things, and submit 2 PRs. |
Done. Ping @fabpot |
👍 |
Thank you @csarrazi. |
fabpot
added a commit
that referenced
this pull request
Feb 18, 2016
…azi) This PR was merged into the 3.1-dev branch. Discussion ---------- [Ldap] Add write support for the Ldap component | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17679 | License | MIT | Doc PR | no This PR implements write support for the Ldap component. Commits ------- dfd04ff Added support for adding / removing / updating Ldap entries
👍 |
/** | ||
* Sets a value for the given attribute. | ||
* | ||
* @param $name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing type
fabpot
added a commit
that referenced
this pull request
Feb 20, 2016
… (csarrazi) This PR was merged into the 3.1-dev branch. Discussion ---------- [Ldap] Fixed PHPDoc for the Ldap component's Entry class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Fixes the remaining comments from PR #17817 Commits ------- a93ce04 Fixed PHPDoc for the Ldap component's Entry class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements write support for the Ldap component.