[Cache] Count cache hits/misses in ProxyAdapter #17734
Conversation
| * - misses: Number of items that have been requested and not found. | ||
| * - uptime: Time that the server is running. | ||
| * - memory_usage: Memory used by the server to store items. | ||
| * - memory_available: Memory allowed to use for storage. |
There was a problem hiding this comment.
The description for memory_available looks confusing to me. Is it the total memory allowed or the remaining memory available?
a7028cd to
6a8510d
Compare
|
The comments in the interface are from the doctrine cache interface and I have exactly the same questions about them. When looking at the implementations there, it seems "uptime" is implemented as "start time", but is it true for all drivers? Some of them fetch stats info that are called "uptime" natively. Does this mean doctrine's stats return values change semantic from implem to implem? |
|
I would instead create a wrapper (possibly in the existing proxy) instead of changing all implementation. Overall, I'm not even sure it's something we need now. So, I'm -0 on this one. |
6a8510d to
2cbd27f
Compare
2cbd27f to
e6f21f9
Compare
|
Updated |
|
👍 |
|
👍 This is definitely going to help us a lot to display this info in the new Cache profiler panel. Thanks @nicolas-grekas! |
|
Thank you @nicolas-grekas. |
…as-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Count cache hits/misses in ProxyAdapter | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17537 partially | License | MIT | Doc PR | - I propose to add this subset of the `Doctrine\Common\Cache\Cache` interface so that we can build data collectors on top and show these stats in the web profiler. ping @javiereguiluz Commits ------- e6f21f9 [Cache] Count cache hits/misses in ProxyAdapter
I propose to add this subset of the
Doctrine\Common\Cache\Cacheinterface so that we can build data collectors on top and show these stats in the web profiler.ping @javiereguiluz