[Process] Fix transient tests for incremental outputs #17650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15617 |
| License | MIT |
| Doc PR | - |
cc1d853 to
76740ed
Compare
| file_put_contents($lock, 'W'); | ||
| $lock = tempnam(sys_get_temp_dir(), __FUNCTION__); | ||
|
|
||
| $p = $this->getProcess(sprintf('%s -r %s', self::$phpBin, escapeshellarg('file_put_contents($s = \''.$uri.'\', $s); flock(fopen('.var_export($lock, true).', \'r\'), LOCK_EX); file_put_contents($s, \'foo\');'))); |
There was a problem hiding this comment.
Why using the uri as content to be written ? this makes the test harder to read IMO. Couldn't we use some hardcoded content instead, and use the uri only as uri ?
76740ed to
90455df
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Feb 2, 2016
…icolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix transient tests for incremental outputs | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15617 | License | MIT | Doc PR | - Commits ------- 90455df [Process] Fix transient tests for incremental outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.