[FrameworkBundle] fix container cache key generation #17620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the actual class name were not taken into, we would not be able to detect inconsistencies between the different configuration formats (PHP, YAML, and XML) as the container built based on the first evaluated configuration format would be cached and reused by tests for the other formats too.
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 31, 2016
…bbuh) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] fix container cache key generation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | If the actual class name were not taken into, we would not be able to detect inconsistencies between the different configuration formats (PHP, YAML, and XML) as the container built based on the first evaluated configuration format would be cached and reused by tests for the other formats too. Commits ------- 29750e5 fix container cache key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the actual class name were not taken into, we would not be able to
detect inconsistencies between the different configuration formats (PHP,
YAML, and XML) as the container built based on the first evaluated
configuration format would be cached and reused by tests for the other
formats too.