10000 Fixed the Bootstrap form theme for inlined checkbox/radio by javiereguiluz · Pull Request #17600 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fixed the Bootstrap form theme for inlined checkbox/radio #17600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

javiereguiluz
Copy link
Member
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14704
License MIT
Doc PR -

@qferr provided the solution for this bug. I only verified it and created the PR.

@aderuwe @JHGitty @tjaadvd all of you took part in the original discussion. Could you please verify if this change fixes your issues? Thanks.

@tjaadvd
Copy link
tjaadvd commented Feb 2, 2016

I can confirm that this fixes the issue!

@javiereguiluz
Copy link
Member Author

@tjaadvd great! Thanks for confirming.

@xabbuh
Copy link
Member
xabbuh commented Feb 3, 2016

👍

Status: Reviewed

javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull request Feb 3, 2016
…iluz)

This PR was merged into the master branch.

Discussion
----------

Fixed form theme for inline checkboxes and radios

Update our form theme for the latest bug fix performed by Symfony in symfony/symfony#17600

Commits
-------

a7e8c57 Fixed form theme for inline checkboxes and radios
@fabpot
Copy link
Member
fabpot commented Feb 4, 2016

Thank you @javiereguiluz.

@fabpot fabpot merged commit cb1a921 into symfony:2.7 Feb 4, 2016
fabpot added a commit that referenced this pull request Feb 4, 2016
…(javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Fixed the Bootstrap form theme for inlined checkbox/radio

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14704
| License       | MIT
| Doc PR        | -

@qferr provided the solution for this bug. I only verified it and created the PR.

@aderuwe @JHGitty @tjaadvd all of you took part in the original discussion. Could you please verify if this change fixes your issues? Thanks.

Commits
-------

cb1a921 Fixed the Bootstrap form theme for inlined checkbox/radio
This was referenced Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0