Introduce 3.1 and 4.0 upgrade files #17583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| Form | ||
| ---- | ||
|
|
||
| * The `choices_as_values` option of the `ChoiceType` has been deprecated and will be removed in Symfony 4.0. |
There was a problem hiding this comment.
In this line I miss the "... use XXX instead" Or is it a removed feature without alternative?
There was a problem hiding this comment.
There is no alternative. The option only still exists as a remainer of the choices transformation done in Symfony 2.7.
|
Can you add line breaks like done in the other UPGRADE files? |
|
@fabpot Sorry, not sure I understand what you mean. |
|
I mean wrapping at around 80 chars. |
|
Oh sure, it seems I wrapped around 100 characters instead. |
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 29, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- Introduce 3.1 and 4.0 upgrade files | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- f68e94a introduce 3.1 and 4.0 upgrade files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.