8000 [2.7] Fix tests by paradajozsef · Pull Request #17582 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[2.7] Fix tests #17582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Next Next commit
[FrameworkBundle] Fix frameworkextension test
  • Loading branch information
paradajozsef committed Jan 27, 2016
commit 26cc962c07cfa197d8bfe16f874a336c3c65888b
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ private function assertUrlPackage(ContainerBuilder $container, DefinitionDecorat
private function assertVersionStrategy(ContainerBuilder $container, Reference $reference, $version, $format)
{
$versionStrategy = $container->getDefinition($reference);
if (null === $version) {
if (null === $version || !$versionStrategy instanceof DefinitionDecorator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is $versionStrategy allowed to be an instance of DefinitionDecorator while $version is null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this fix is wrong.

$this->assertEquals('assets.empty_version_strategy', (string) $reference);
} else {
$this->assertEquals('assets.static_version_strategy', $versionStrategy->getParent());
Expand Down
0