8000 [WebProfilerBundle] Add HTTP return code in the Ajax request list table by kucharovic · Pull Request #17540 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Add HTTP return code in the Ajax request list table #17540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WebProfilerBundle] Add HTTP return code in the Ajax request list table #17540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d5afc4
[WebProfilerBundle] Add HTTP return code in the Ajax request list table
kucharovic Jan 26, 2016
2cb84ca
Added background color according to response
kucharovic Jan 26, 2016
0c85a1d
Removed background color from successful responses
kucharovic Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[WebProfilerBundle] Add HTTP return code in the Ajax request list table 
Q | A
---|---
Bug fix? | no
New feature? | yes
BC breaks? | no
Deprecations? | no
Tests pass? | yes
Fixed tickets | #17518
License | MIT
Doc PR | -
  • Loading branch information
@kucharovic
kucharovic committed Jan 26, 2016
commit 1d5afc427fb21fb7b1eb753983ec68ec92fdc259
1 change: 1 addition & 0 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/ajax.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<thead>
<tr>
<th>Method</th>
<th>Status</th>
<th>URL</th>
<th>Time</th>
<th>Profile</th>
Expand Down
9 changes: 9 additions & 0 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@
methodCell.textContent = request.method;
row.appendChild(methodCell);

var statusCodeCell = document.createElement('td');
if (request.statusCode) {
statusCodeCell.textContent = request.statusCode;
} else {
statusCodeCell.textContent = '-';
}
row.appendChild(statusCodeCell);

var pathCell = document.createElement('td');
pathCell.className = 'sf-ajax-request-url';
if ('GET' === request.method) {
Expand Down Expand Up @@ -241,6 +249,7 @@
stackElement.duration = new Date() - stackElement.start;
stackElement.loading = false;
stackElement.error = self.status < 200 || self.status >= 400;
stackElement.statusCode = self.status;
stackElement.profile = self.getResponseHeader("X-Debug-Token");
stackElement.profilerUrl = self.getResponseHeader("X-Debug-Token-Link");

Expand Down
0