[Asset] Version as service #17532
[Asset] Version as service #17532
Conversation
| ->ifTrue(function ($v) { | ||
| return (null !== $v['version_strategy'] && null !== $v['version']); | ||
| }) | ||
| ->thenInvalid('You cannot use version_strategy and version settings in assets configuration.') |
There was a problem hiding this comment.
You cannot use both "version_strategy" and "version" at the same time under "assets".
|
👍 |
|
@fabpot done, test fails seems unrelated (also appveyor marked as green, but it have failed tests) Are you expect invalid message like this - "for the "{"base_urls":["//example.com"],"version":1,"version_strategy":"foo","version_format":null,"base_path":""}" package" ? |
|
Packages have names, right? |
|
@fabpot right. But "thenInvalid" function just json encode node. If you want package name under %s, I can check how it can be done. |
|
If getting the package name is possible, that would be better, if not, just keep it without anything. Having the config in there would look weird. |
|
@fabpot I remove package name, maybe in next PR provide solution. On first look it is not so easy to output there package name. |
|
Thank you @ewgRa. |
This PR was merged into the 2.7 branch. Discussion ---------- Revert the merge of #7141 I shouldn't have merged #7141 into the `2.7` branch as the related code PR (symfony/symfony#17532) was released with Symfony 3.1. Commits ------- 0f7c7d5 Revert "minor #7141 Added "How to Use a Custom Version Strategy for Assets" (teohhanhui, javiereguiluz)"
While I working on #14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service.
This PR implementation of this idea.
Now it is possible to do something like this:
There is can be some conflicts with #16511 when it will be in master