8000 [Serializer] Ensure that groups are strings by dunglas · Pull Request #17430 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Ensure that groups are strings #17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Serializer] Ensure that groups are strings #17430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1daed82
[Serializer] Ensure that groups are strings
dunglas Jan 18, 2016
b8a9e7c
[Serializer] YamlLoader: groups must be an array
dunglas Jan 19, 2016
65503f3
Add file, class and attribute name
dunglas Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add file, class and attribute name
  • Loading branch information
@dunglas
dunglas committed Jan 26, 2016
commit 65503f3d45e132ac07689be975a9cc520517eb0e
4 changes: 2 additions & 2 deletions src/Symfony/Component/Serializer/Mapping/Loader/YamlFileLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata)

if (isset($data['groups'])) {
if (!is_array($data['groups'])) {
throw new MappingException('The "groups" key must be an array of strings.');
throw new MappingException('The "groups" key must be an array of strings in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName());
}

foreach ($data['groups'] as $group) {
if (!is_string($group)) {
throw new MappingException('Group names must be strings.');
throw new MappingException('Group names must be strings in "%s" for the attribute "%s" of the class "%s".', $this->file, $attribute, $classMetadata->getName());
}

$attributeMetadata->addGroup($group);
Expand Down
0