8000 Fix max width for multibyte keys in choice question by marek-pietrzak-tg · Pull Request #17314 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix max width for multibyte keys in choice question #17314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix max width for multibyte keys in choice question #17314

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a1f710
Fix max width for choice question
marek-pietrzak-tg Jan 8, 2016
7595969
CS fix
marek-pietrzak-tg Jan 8, 2016
8000
2188655
change [] to array() for php5.3 compatibility
marek-pietrzak-tg Jan 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change [] to array() for php5.3 compatibility
  • Loading branch information
@marek-pietrzak-tg
marek-pietrzak-tg committed Jan 8, 2016
commit 2188655267aa8e8f0611bef24feb09f769bbf573
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Helper/QuestionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ protected function writePrompt(OutputInterface $output, Question $question)
$message = $question->getQuestion();

if ($question instanceof ChoiceQuestion) {
$maxWidth = max(array_map([$this, 'strlen'], array_keys($question->getChoices())));
$maxWidth = max(array_map(array($this, 'strlen'), array_keys($question->getChoices())));

$messages = (array) $question->getQuestion();
foreach ($question->getChoices() as $key => $value) {
Expand Down
0