8000 [AssetsHelper] use proper class to fetch asset version strategy property by twencl · Pull Request #17260 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetsHelper] use proper class to fetch asset version strategy property #17260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[AssetsHelper] use proper class to fetch asset version strategy property #17260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[AssetsHelper] use proper class to fetch asset version strategy property
  • Loading branch information
@twencl
twencl committed Jan 4, 2016
commit 3fc5fe4ce5c8ae2d5185824c87187cc3020b2a1e
7 changes: 6 additions & 1 deletion src/Symfony/Bundle/FrameworkBundle/Templating/Helper/AssetsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,13 @@ private function getLegacyAssetUrl($path, $packageName = null, $version = null)
{
if ($version) {
$package = $this->packages->getPackage($packageName);
$class = new \ReflectionClass($package);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we just do $v = new \ReflectionProperty('Symfony\Component\Asset\Package', 'versionStrategy'); instead of the while loop?

$v = new \ReflectionProperty($package, 'versionStrategy');
while ('Symfony\Component\Asset\Package' !== $class->getName()) {
$class = $class->getParentClass();
}

$v = $class->getProperty('versionStrategy');
$v->setAccessible(true);

$currentVersionStrategy = $v->getValue($package);
Expand Down
0