[Form] fixed DateTimeType tests using "date_widget"="choice". #17248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8611463 to
3a8fc99
Compare
3a8fc99 to
fffc6fa
Compare
|
👍 (should be merged into the Status: Reviewed |
| 'time_widget' => 'choice', | ||
| 'input' => 'datetime', | ||
| 'with_minutes' => false, | ||
| )); | ||
|
|
||
| $form->setData(new \DateTime('2010-06-02 03:04:05 UTC')); |
There was a problem hiding this comment.
Why did you make this change? Doesn't it change the test?
There was a problem hiding this comment.
Nvm, it's clear after re-reading your PR :) 👍
|
👍 |
|
Good catch, thanks @adrienlucas. |
Tobion
added a commit
that referenced
this pull request
Jan 4, 2016
…ice". (Adrien LUCAS) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17248). Discussion ---------- [Form] fixed DateTimeType tests using "date_widget"="choice". | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no As said in the [documentation](http://symfony.com/doc/current/reference/forms/types/datetime.html#years), the default years available in the ``DateType`` go from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the ``"date_widget"="choice"`` without defining a ``"years"`` option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list. This PR fixes the issue by setting the ``"years"`` option to ``"2010"`` for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently. Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore. Commits ------- be20e89 Fix Form's DateTimeType tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in the documentation, the default years available in the
DateTypego from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the"date_widget"="choice"without defining a"years"option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list.This PR fixes the issue by setting the
"years"option to"2010"for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently.Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore.