10000 [Form] fix Catchable Fatal Error if choices is not an array by Gladhon · Pull Request #17163 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] fix Catchable Fatal Error if choices is not an array #17163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] fix Catchable Fatal Error if choices is not an array #17163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,11 @@ public function configureOptions(OptionsResolver $resolver)
return $choices;
}

ChoiceType::normalizeLegacyChoices($choices, $choiceLabels);
if (null === $choices) {
return;
}

return $choices;
return ChoiceType::normalizeLegacyChoices($choices, $choiceLabels);
};

// BC closure, to be removed in 3.0
Expand Down Expand Up @@ -503,26 +505,30 @@ private function createChoiceListView(ChoiceListInterface $choiceList, array $op
* are lost. Store them in a utility array that is used from the
* "choice_label" closure by default.
*
* @param array $choices The choice labels indexed by choices.
* Labels are replaced by generated keys.
* @param object $choiceLabels The object that receives the choice labels
* indexed by generated keys.
* @param int $nextKey The next generated key.
* @param array|\Traversable $choices The choice labels indexed by choices.
* @param object $choiceLabels The object that receives the choice labels
* indexed by generated keys.
* @param int $nextKey The next generated key.
*
* @return array The choices in a normalized array with labels replaced by generated keys.
*
* @internal Public only to be accessible from closures on PHP 5.3. Don't
* use this method as it may be removed without notice and will be in 3.0.
*/
public static function normalizeLegacyChoices(array &$choices, $choiceLabels, &$nextKey = 0)
public static function normalizeLegacyChoices($choices, $choiceLabels, &$nextKey = 0)
{
$normalizedChoices = array();

foreach ($choices as $choice => $choiceLabel) {
if (is_array($choiceLabel)) {
$choiceLabel = ''; // Dereference $choices[$choice]
self::normalizeLegacyChoices($choices[$choice], $choiceLabels, $nextKey);
if (is_array($choiceLabel) || $choiceLabel instanceof \Traversable) {
$normalizedChoices[$choice] = self::normalizeLegacyChoices($choiceLabel, $choiceLabels, $nextKey);
continue;
}

$choiceLabels->labels[$nextKey] = $choiceLabel;
$choices[$choice] = $nextKey++;
$normalizedChoices[$choice] = $nextKey++;
}

return $normalizedChoices;
}
}
15 changes: 15 additions & 0 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,21 @@ public function testSubmitSingleNonExpandedObjectChoices()
$this->assertTrue($form->isSynchronized());
}

/**
* @group legacy
*/
public function testLegacyNullChoices()
{
$form = $this->factory->create('choice', null, array(
'multiple' => false,
'expanded' => false,
'choices' => null,
));
$this->assertNull($form->getConfig()->getOption('choices'));
$this->assertFalse($form->getConfig()->getOption('multiple'));
$this->assertFalse($form->getConfig()->getOption('expanded'));
}

/**
* @group legacy
*/
Expand Down
0