[Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM #17108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e243be7 to
cb23212
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 22, 2015
…nyRoutes on HHVM (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - phpunit reports: - before: `Memory: 430.91Mb` - after: `Memory: 21.26Mb` Commits ------- cb23212 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
|
@nicolas-grekas should this be reported to the HHVM team ? It may indicate a bug in HHVM |
765E
|
@stof in fact I think it's been already fixed on hhvm; locally with a higher version of it, I get memory freed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpunit reports:
Memory: 430.91MbMemory: 21.26Mb