-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Added 451 status code #17095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, one issue and two PR .. this HTTP Code is famous! Let's merge it. 😄 |
@@ -67,6 +67,7 @@ class Response | |||
const HTTP_PRECONDITION_REQUIRED = 428; // RFC6585 | |||
const HTTP_TOO_MANY_REQUESTS = 429; // RFC6585 | |||
const HTTP_REQUEST_HEADER_FIELDS_TOO_LARGE = 431; // RFC6585 | |||
const HTTP_UNAVAILABLE_FOR_LEGAL_REASONS = 451; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the comment with the RFC number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof It hasn't been assigned one yet.
As I understand it's been accepted but the RFC editor has some things still to do before it's published and assigned a number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the reason I didn't make a PR yet yesterday, it was still a draft so I could not attach an RFC.
Is the master the right branch? I think this could easily be addd to 2.3, 2.7, 2.8 and 3.0 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the branch, according to symfony/symfony-docs#6045, this is not the case. master
is the right branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is not a new feature imo, it doesn't add anything functional.
Thank you @AndrewCarterUK. |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17095). Discussion ---------- [HttpFoundation] Added 451 status code | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT https://datatracker.ietf.org/doc/draft-ietf-httpbis-legally-restricted-status/?include_text=1 The HTTP 451 status code was approved by the ISG a few days ago on the 18th December '15. Commits ------- df8952f Added 451 status code
@JHGitty see #17982 |
https://datatracker.ietf.org/doc/draft-ietf-httpbis-legally-restricted-status/?include_text=1
The HTTP 451 status code was approved by the ISG a few days ago on the 18th December '15.