8000 [2.3] Static Code Analysis for Components by kalessil · Pull Request #17085 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.3] Static Code Analysis for Components #17085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[2.3] Static Code Analysis for Components #17085

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
24839fb
Php Inspections (EA Extended): remaining mkdir race conditions, conti…
kalessil Dec 21, 2015
017ba7f
Php Inspections (EA Extended): review before PR
kalessil Dec 21, 2015
eaada24
Php Inspections (EA Extended): use sprintf for exception messages, us…
kalessil Dec 21, 2015
4bdc26b
Php Inspections (EA Extended): continue 2 -> break, exceptions messag…
kalessil Dec 23, 2015
e39154e
Php Inspections (EA Extended): correct exceptions messages
kalessil Dec 23, 2015
c3a4f7f
Php Inspections (EA Extended): make sprintf pattern (inline variable)…
kalessil Dec 25, 2015
0016474
Php Inspections (EA Extended): make sprintf pattern (inline variable)…
kalessil Dec 25, 2015
918a018
Php Inspections (EA Extended): make sprintf pattern inline variables …
kalessil Dec 28, 2015
18ce233
Php Inspections (EA Extended): exceptions wording - "a"s removed
kalessil Dec 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Php Inspections (EA Extended): make sprintf pattern (inline variable)… 
… consistent
  • Loading branch information
@kalessil
kalessil committed Dec 25, 2015
commit 001647476be433fcce00b98653fff6a434dea054
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/HeaderBag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function __toString()
foreach ($this->headers as $name => $values) {
$name = implode('-', array_map('ucfirst', explode('-', $name)));
foreach ($values as $value) {
$content .= sprintf("%-${max}s %s", $name.':', $value);
$content .= sprintf("%-${max}s %s\r\n", $name.':', $value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I prefer {$max}; it generates much cleaner tokens when parsing (think e.g. static analyzers)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It were 4 more cases with sprintf and inline variables, as ${...} structure. Should I make adjustments to {$...} then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${...} -> {$...}: done

}
}

Expand Down
0