8000 [FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method. by hhamon · Pull Request #17033 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method. #17033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2015
Merged

[FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method. #17033

merged 1 commit into from
Dec 18, 2015

Conversation

hhamon
Copy link
Contributor
@hhamon hhamon commented Dec 16, 2015
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@hhamon hhamon force-pushed the fix-phpdoc-base-controller branch from f8e8711 to 4135a6b Compare December 16, 2015 16:29
xabbuh
xabbuh reviewed Dec 17, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php
* @param string|FormTypeInterface $type The built type of the form
* @param mixed $data The initial data for the form
* @param array $options Options for the form
* @param string $type The fully qualified namespace of the form type class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "The fully qualified class name of the form type"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;)

@hhamon hhamon force-pushed the fix-phpdoc-base-controller branch from 4135a6b to 3d0c4dd Compare December 18, 2015 07:55
@xabbuh
Copy link
Member
xabbuh commented Dec 18, 2015

👍

Status: Reviewed

@nicolas-grekas
Copy link
Member

Thank you @hhamon.

@nicolas-grekas nicolas-grekas merged commit 3d0c4dd into symfony:3.0 Dec 18, 2015
nicolas-grekas added a commit that referenced this pull request Dec 18, 2015
@nicolas-grekas
minor #17033 [FrameworkBundle] fixes outdated phpdoc on Controller::c…
a6c0025 
…reateForm() method. (hhamon)

This PR was merged into the 3.0 branch.

Discussion
----------

[FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

3d0c4dd [FrameworkBundle] fixes outdated phpdoc on Controller::createForm() method.
@hhamon hhamon deleted the fix-phpdoc-base-controller branch December 29, 2015 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hhamon @xabbuh @nicolas-grekas @carsonbot
0