[Form] Deprecate the "choices_as_values" option of ChoiceType #16994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
👍 |
|
Is there any way to "feature detect" whether or not this option needs to be set (to |
|
@craue |
|
@stof, thanks. I wonder why |
|
@craue because the changelog files are incomplete, as reported already. Latest removals have been forgotten |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2015
…iceType (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Form] Deprecate the "choices_as_values" option of ChoiceType | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9aa5507 [Form] Deprecate the "choices_as_values" option of ChoiceType
Merged
|
I am using Symfony 3.1.2 and I receive the message: The "choices_as_values" option is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore. but I DON'T use "choices_as_values". I just use "choices" as shown below. Do I miss something ? Stack trace in case it helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
<
5DEF
a rel="nofollow" class="Link--inTextBlock" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":458058,"auth_type":"LOG_IN","originating_url":"https://github.com/symfony/symfony/pull/16994","user_id":null}}" data-hydro-click-hmac="e0891e9794597ee05eee8329937ee9fe27a55eef8a0cfbecb7f9d0afdb664d7d" data-test-selector="comments-sign-in-link" href="/login?return_to=https%3A%2F%2Fgithub.com%2Fsymfony%2Fsymfony%2Fpull%2F16994">Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.