[Validator] Target aware class constraints #16978
Conversation
391d7b6 to
604e6a1
Compare
| */ | ||
| public function getTargets() | ||
| { | ||
| return Constraint::CLASS_CONSTRAINT; |
There was a problem hiding this comment.
Just wondering: Why don't you think it could be useful for property constraints ?
There was a problem hiding this comment.
I see target awareness like a scope widening feature.
So called class constraints are lexically applied to the class but usually have the validated instance as their scope (i.e. The constraint is checking that the current instance respects such and such invariant). A TA class constraint is using the class as its scope (i.e. The constraint is checking that the current instance does not break such and such invariant among all the other instances of the class).
Following the same reasoning, property constraints have the validated property as their scope (i.e. The constraint is checking that the current property respects such and such invariant). Widening the scope of such constraint to the current instance is already possible using a class constraint (with a custom path).
f7ba807 to
d63d8d5
Compare
|
As @ogizanagi mentionned in #16981 (comment)
I didn't see fit to alter the semantic of this loader. If you think it would be a better way to do it. I will do so with the appropriate tests. That would mean the deprecation of the next PR would be limited to custom constraint loaders. |
d63d8d5 to
697833b
Compare
|
I rebased both PR. The PHP 5.6 Travis build fails because of failling tests in Framework, as far as I can tell it's unrelated to this PR. |
This PR is the first part of #16969
It basically creates a new
TargetAwareConstraintInterfaceand a trait for its implementation.The idea is that a constraint implementing this interface would need to be aware of its target (it makes sense only for Class Constraints). For class constraints, the target is the class the constraint was declared on.
It provides also support for YamlFileLoader, XmlFileLoader and AnnotationLoader (only for Class Constraints) with appropriate tests.
AppVeyor failing tests are related to the HttpFoundation Component.
HHVM failing tests are related to the Process Component.
In both case, it's unrelated to this PR.