-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PropertyInfo] Cache support #16917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[PropertyInfo] Cache support #16917
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
adb4493
[PropertyInfo] Cache support
dunglas 6cc4445
[PropertyInfo] Cache Decorator
dunglas 681bc86
[PropertyInfo] Deal with not serializable context
dunglas 4008130
wip
dunglas 9396a19
[PropertyInfo] PSR-6 cache
dunglas 43f3446
Replace symfony/cache by psr/cache-implementation in suggest
dunglas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
wip
- Loading branch information
commit 40081309ab0dbc62c1bcb08b8f31c16ff3324137
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
src/Symfony/Component/PropertyInfo/Tests/PropertyInfoCacheExtractorTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\PropertyInfo\Tests; | ||
|
||
use Symfony\Component\PropertyInfo\PropertyInfoCacheExtractor; | ||
|
||
/** | ||
* @author Kévin Dunglas <dunglas@gmail.com> | ||
*/ | ||
class PropertyInfoCacheExtractorTest extends AbstractPropertyInfoExtractorTest | ||
{ | ||
public function setUp() | ||
{ | ||
parent::setUp(); | ||
|
||
$this->propertyInfo = new PropertyInfoCacheExtractor($this->propertyInfo, new ArrayCac); | ||
} | ||
|
||
public function testCache() | ||
{ | ||
$this->assertSame('short', $this->propertyInfo->getShortDescription('Foo', 'bar', array())); | ||
$this->assertSame('short', $this->propertyInfo->getShortDescription('Foo', 'bar', array())); | ||
} | ||
|
||
public function testNotSerializableContext() | ||
{ | ||
$this->assertSame('short', $this->propertyInfo->getShortDescription('Foo', 'bar', array('foo' => function () {}))); | ||
} | ||
|
||
public function testEscape() | ||
{ | ||
$reflectionMethod = new \ReflectionMethod($this->propertyInfo, 'escape'); | ||
$reflectionMethod->setAccessible(true); | ||
|
||
$this->assertSame('foo_bar', $this->propertyInfo->escape('foo_95bar')); | ||
$this->assertSame('foo_95bar', $this->propertyInfo->escape('foo_9595bar')); | ||
$this->assertSame('foo{bar}', $this->propertyInfo->escape('foo_123bar_125')); | ||
$this->assertSame('foo(bar)', $this->propertyInfo->escape('foo_40bar_41')); | ||
$this->assertSame('foo/bar', $this->propertyInfo->escape('foo_47bar')); | ||
$this->assertSame('foo\bar', $this->propertyInfo->escape('foo_92bar')); | ||
$this->assertSame('foo@bar', $this->propertyInfo->escape('foo_64bar')); | ||
$this->assertSame('foo:bar', $this->propertyInfo->escape('foo_58bar')); | ||
} | ||
} |
39 changes: 0 additions & 39 deletions
39
src/Symfony/Component/PropertyInfo/Tests/PropertyInfoExtractorCacheDecoratorTest.php
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setUp is a protected method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick search revealed there's few more occurrences. I'll send a PR to fix them.