8000 [Serializer] PropertyNormalizer shouldn't set static properties by boekkooi · Pull Request #16453 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] PropertyNormalizer shouldn't set static properties #16453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2015
Merged

[Serializer] PropertyNormalizer shouldn't set static properties #16453

merged 1 commit into from
Nov 5, 2015

Conversation

boekkooi
Copy link
Contributor
@boekkooi boekkooi commented Nov 4, 2015
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR fixes a bug where static properties where set by the PropertyNormalizer.

@boekkooi boekkooi force-pushed the serializer-property-normalizer-static branch from 292a59c to b15bdca Compare November 4, 2015 07:01
@dunglas
Copy link
Member
dunglas commented Nov 4, 2015

👍

@boekkooi
Copy link
Contributor Author
boekkooi commented Nov 5, 2015

Status: Reviewed

@xabbuh
Copy link
Member
xabbuh commented Nov 5, 2015

👍

@fabpot
Copy link
Member
fabpot commented Nov 5, 2015

Thank you @boekkooi.

@fabpot fabpot merged commit b15bdca into symfony:2.7 Nov 5, 2015
fabpot added a commit that referenced this pull request Nov 5, 2015
@fabpot
bug #16453 [Serializer] PropertyNormalizer shouldn't set static prope…
e21bf56 
…rties (boekkooi)

This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] PropertyNormalizer shouldn't set static properties

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR fixes a bug where static properties where set by the PropertyNormalizer.

Commits
-------

b15bdca [Serializer] PropertyNormalizer shouldn't set static properties
@xabbuh xabbuh mentioned this pull request Nov 7, 2015
Closed
@fabpot fabpot mentioned this pull request Nov 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boekkooi @dunglas @xabbuh @fabpot @carsonbot
0