[travis] session.gc_probability=0 to fix transient tests on hhvm #16443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fc43ce to
b2688df
Compare
b2688df to
b4dd254
Compare
|
So saving and fetching session files works on HHVM, but GC doesn't? Or why does GC fail? |
|
I really don't know... Yet, builds fail transiently with this error... |
|
Could be https://www.leaseweb.com/labs/2012/08/ps_files_cleanup_dir-permission-denied/ or facebook/hhvm#6302 Anyway, it doesn't hurt to set gc probability to 0 for tests. So 👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2015
… on hhvm (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [travis] session.gc_probability=0 to fix transient tests on hhvm | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15617 | License | MIT | Doc PR | - Should fix tests failing with: `ps_files_cleanup_dir: opendir(/var/lib/hhvm/sessions) failed: Permission denied (13)` Commits ------- b4dd254 [travis] session.gc_probability=0 to fix transient tests on hhvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix tests failing with:
ps_files_cleanup_dir: opendir(/var/lib/hhvm/sessions) failed: Permission denied (13)