8000 checkCredentials() force it to be an affirmative yes! by weaverryan · Pull Request #16395 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

checkCredentials() force it to be an affirmative yes! #16395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

checkCredentials() force it to be an affirmative yes! #16395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53eea05
Changing the behavior of GuardAuthenticatorInterface::checkCredential…
weaverryan Oct 30, 2015
c23ac46
Fixing small typos thanks to comments
weaverryan Oct 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing small typos thanks to comments
  • Loading branch information
@weaverryan
weaverryan committed Oct 30, 2015
commit c23ac4632c50278e7d87fdeb714dbf7996d70ef4
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Guard/GuardAuthenticatorInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function getCredentials(Request $request);
public function getUser($credentials, UserProviderInterface $userProvider);

/**
* Return true if the credentials are valid.
* Returns true if the credentials are valid.
*
* If any value other than true is returned, authentication will
* fail. You may also throw an AuthenticationException if you wish
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Security/Guard/Provider/GuardAuthenticationProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ private function authenticateViaGuard(GuardAuthenticatorInterface $guardAuthenti

$this->userChecker->checkPreAuth($user);
if (true !== $guardAuthenticator->checkCredentials($token->getCredentials(), $user)) {
throw new BadCredentialsException(sprintf('Authentication failed because %s::checkCredentials() did not return true', get_class($guardAuthenticator)));
};
throw new BadCredentialsException(sprintf('Authentication failed because %s::checkCredentials() did not return true.', get_class($guardAuthenticator)));
}
$this->userChecker->checkPostAuth($user);

// turn the UserInterface into a TokenInterface
Expand Down
0