8000 [HttpFoundation] fix expected argument type docblock by xabbuh · Pull Request #16373 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] fix expected argument type docblock #16373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2015
Merged

[HttpFoundation] fix expected argument type docblock #16373

merged 1 commit into from
Oct 29, 2015

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 28, 2015
Q A
Fixed tickets
License MIT

@xabbuh
Copy link
Member Author
xabbuh commented Oct 28, 2015

Actually, we should probably change the type for the other get*() methods too. What do you think?

@Tobion
Copy link
Contributor
Tobion commented Oct 29, 2015

Yes getDigits, getAlnum and getAlpha must be changed to string.

@xabbuh xabbuh force-pushed the argument-type-docblock branch from e5c6c9a to 1c01ebc Compare October 29, 2015 18:47
@xabbuh
Copy link
Member Author
xabbuh commented Oct 29, 2015

Updated those three methods as well.

@Tobion
Copy link
Contributor
Tobion commented Oct 29, 2015

👍

Status: Reviewed

@fabpot
Copy link
Member
fabpot commented Oct 29, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 1c01ebc into symfony:2.3 Oct 29, 2015
fabpot added a commit that referenced this pull request Oct 29, 2015
@fabpot
minor #16373 [HttpFoundation] fix expected argument type docblock (xa…
f59286b 
…bbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] fix expected argument type docblock

| Q             | A
| ------------- | ---
| Fixed tickets |
| License       | MIT

Commits
-------

1c01ebc fix expected argument type docblock
@xabbuh xabbuh deleted the argument-type-docblock branch October 29, 2015 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @Tobion @fabpot @carsonbot
0