[HttpFoundation] don't call constructors on Mongo mock objects #16370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the parent constructor of the mocked `Mongo` class tries to connect to a local MongoDB server which fails in case no local server was configured. Similarly, when the parent constructor of the mocked `MongoCollection` class is called it performs checks on the passed arguments which fails again when a connection was not established successfully before.
|
@EmanueleMinotto Can you confirm that this works for you too? |
|
it works for me 👍 |
|
Thanks @xabbuh and @EmanueleMinotto |
Tobion
added a commit
that referenced
this pull request
Oct 28, 2015
…bjects (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] don't call constructors on Mongo mock objects | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16287 | License | MIT | Doc PR | Calling the parent constructor of the mocked `Mongo` class tries to connect to a local MongoDB server which fails in case no local server was configured. Similarly, when the parent constructor of the mocked `MongoCollection` class is called it performs checks on the passed arguments which fails again when a connection was not established successfully before. Commits ------- 6541b8b don't call constructors on Mongo mock objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the parent constructor of the mocked
Mongoclass tries toconnect to a local MongoDB server which fails in case no local server
was configured.
Similarly, when the parent constructor of the mocked
MongoCollectionclass is called it performs checks on the passed arguments which fails
again when a connection was not established successfully before.