8000 [TEMPLATING] PHP's app template location is invalid by rvanginneken · Pull Request #16220 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TEMPLATING] PHP's app template location is invalid #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[TEMPLATING] PHP's app template location is invalid #16220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c084c0
[TEMPLATING] PHP's app template location is invalid
rvanginneken Oct 12, 2015
17d732f
[CodingStandards]
rvanginneken Oct 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Templating/TemplateReference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function all()
*/
public function getPath()
{
return $this->parameters['name'];
return 'views/'.$this->parameters['name'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely not the right way to solve this issue, as it forces everyone to store templates in the "views" directory. While this might be the case for Symfony projects, it's not necessarily the case for other projects using the templating component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright. I used it because same logic is applied in frameworkbundle. But I see what you mean.

}

/**
Expand Down
0