[VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster #16129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
👍 |
| { | ||
| if (!$prev instanceof \Exception) { | ||
| @trigger_error('Providing the $prev exception as 2nd argument when instanciating a '.__CLASS__.' is deprecated since version 2.8 and will be removed in 3.0. Provide it as first argument instead.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
Isn't the real change that you should not pass the caster anymore (which implies that the exception is now the first argument)?
There was a problem hiding this comment.
Agree, the constructor should only have one argument (without typehint) and the BC layer implementation should be changed.
There was a problem hiding this comment.
I changed the deprecation message (but not the logic around, which looks fine to me)
…construct, removing $caster
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
…Exception::__construct, removing $caster (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 02b86b0 [VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster
fabpot
added a commit
that referenced
this pull request
Oct 6, 2015
…ages (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][VarDumper] tweak some deprecation messages | Q | A | ------------- | --- | Fixed tickets | #16129, #16135 | License | MIT I was a bit too slow with reviewing. Commits ------- 536045f tweak some deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.