8000 Fixed typos by pborreli · Pull Request #16098 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Fixed typos #16098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ protected function loadCacheDriver($cacheName, $objectManagerName, array $cacheD
/**
* Returns a modified version of $managerConfigs.
*
* The manager called $autoMappedManager will map all bundles that are not mepped by other managers.
* The manager called $autoMappedManager will map all bundles that are not mapped by other managers.
*
* @param array $managerConfigs
* @param array $bundles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public function write($sessionId, $data)
$mergeStmt->bindParam(':data', $encoded, \PDO::PARAM_STR);
$mergeStmt->bindValue(':time', time(), \PDO::PARAM_INT);

//Oracle has a bug that will intermitently happen if you
//Oracle has a bug that will intermittently happen if you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it was wrong in the original comment too but, should't we add a white space between the // and the actual comment content?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I guess we can

//have only 1 bind on a CLOB field for 2 different statements
//(INSERT and UPDATE in this case)
if ('oracle' == $this->con->getDatabasePlatform()->getName()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function testFixManagersAutoMappingsWithTwoAutomappings()
);

$bundles = array(
'FristBundle' => 'My\FristBundle',
'FirstBundle' => 'My\FirstBundle',
'SecondBundle' => 'My\SecondBundle',
);

Expand Down Expand Up @@ -97,7 +97,7 @@ public function getAutomappingData()
array(),
array(
'mappings' => array(
'FristBundle' => array(
'FirstBundle' => array(
'mapping' => true,
'is_bundle' => true,
),
Expand Down Expand Up @@ -131,7 +131,7 @@ public function getAutomappingData()
),
array(
'mappings' => array(
'FristBundle' => array(
'FirstBundle' => array(
'mapping' => true,
'is_bundle' => true,
),
Expand All @@ -152,7 +152,7 @@ public function testFixManagersAutoMappings(array $originalEm1, array $originalE
);

$bundles = array(
'FristBundle' => 'My\FristBundle',
'FirstBundle' => 'My\FirstBundle',
'SecondBundle' => 'My\SecondBundle',
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function testGetControllerInvokableService()
*/
public function testGetControllerOnNonUndefinedFunction($controller, $exceptionName = null, $exceptionMessage = null)
{
// All this logic needs to be duplicated, since calling parent::testGetControllerOnNonUndefinedFunction will override the expected excet 8000 ion and not use the regex
// All this logic needs to be duplicated, since calling parent::testGetControllerOnNonUndefinedFunction will override the expected exception and not use the regex
$resolver = $this->createControllerResolver();
$this->setExpectedExceptionRegExp($exceptionName, $exceptionMessage);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function testProcessThrowAnExceptionIfTheServiceIsNotASubclassOfCommand()
$container->compile();
}

public function testHttpKernelRegisterCommandsIngoreCommandAsAService()
public function testHttpKernelRegisterCommandsIgnoreCommandAsAService()
{
$container = new ContainerBuilder();
$container->addCompilerPass(new AddConsoleCommandPass());
Expand Down
6D40 10 changes: 5 additions & 5 deletions src/Symfony/Bundle/FrameworkBundle/Tests/Translation/TranslatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,11 @@ protected function getContainer($loader)
return $container;
}

public function getTranslator($loader, $options = array(), $loaderFomat = 'loader', $translatorClass = '\Symfony\Bundle\FrameworkBundle\Translation\Translator')
public function getTranslator($loader, $options = array(), $loaderFormat = 'loader', $translatorClass = '\Symfony\Bundle\FrameworkBundle\Translation\Translator')
{
$translator = $this->createTranslator($loader, $options, $translatorClass, $loaderFomat);
$translator = $this->createTranslator($loader, $options, $translatorClass, $loaderFormat);

if ('loader' === $loaderFomat) {
if ('loader' === $loaderFormat) {
$translator->addResource('loader', 'foo', 'fr');
$translator->addResource('loader', 'foo', 'en');
$translator->addResource('loader', 'foo', 'es');
Expand Down Expand Up @@ -260,12 +260,12 @@ public function testWarmup()
$this->assertEquals('répertoire', $translator->trans('folder'));
}

private function createTranslator($loader, $options, $translatorClass = '\Symfony\Bundle\FrameworkBundle\Translation\Translator', $loaderFomat = 'loader')
private function createTranslator($loader, $options, $translatorClass = '\Symfony\Bundle\FrameworkBundle\Translation\Translator', $loaderFormat = 'loader')
{
return new $translatorClass(
$this->getContainer($loader),
new MessageSelector(),
array($loaderFomat => array($loaderFomat)),
array($loaderFormat => array($loaderFormat)),
$options
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ protected function normalizeToken($token)
/**
* Seeks to a non-whitespace token.
*/
private function seekToNextReleventToken(\Iterator $tokenIterator)
private function seekToNextRelevantToken(\Iterator $tokenIterator)
{
for (; $tokenIterator->valid(); $tokenIterator->next()) {
$t = $tokenIterator->current();
Expand Down Expand Up @@ -153,7 +153,7 @@ protected function parseTokens($tokens, MessageCatalogue $catalog)
$tokenIterator->seek($key);

foreach ($sequence as $item) {
$this->seekToNextReleventToken($tokenIterator);
$this->seekToNextRelevantToken($tokenIterator);

if ($this->normalizeToken($tokenIterator->current()) == $item) {
$tokenIterator->next();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ public function testSetAclUser()

try {
$acl->isGranted($permissionMap->getMasks('OWNER', null), array($securityIdentity1));
$this->fail('NoAceFoundException not throwed');
$this->fail('NoAceFoundException not thrown');
} catch (NoAceFoundException $e) {
}

try {
$acl->isGranted($permissionMap->getMasks('OPERATOR', null), array($securityIdentity2));
$this->fail('NoAceFoundException not throwed');
$this->fail('NoAceFoundException not thrown');
} catch (NoAceFoundException $e) {
}
}
Expand Down Expand Up @@ -133,13 +133,13 @@ public function testSetAclRole()

try {
$acl->isGranted($permissionMap->getMasks('VIEW', null), array($userSecurityIdentity));
$this->fail('NoAceFoundException not throwed');
$this->fail('NoAceFoundException not thrown');
} catch (NoAceFoundException $e) {
}

try {
$acl->isGranted($permissionMap->getMasks('OPERATOR', null), array($userSecurityIdentity));
$this->fail('NoAceFoundException not throwed');
$this->fail('NoAceFoundException not thrown');
} catch (NoAceFoundException $e) {
}
}
Expand Down
0