[WIP] Remove remaining deprecated interfaces #16097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
881d1eb to
2a2fdeb
Compare
| @@ -901,10 +901,7 @@ private function relativize($xpath) | |||
| $expression = substr($expression, strlen($parenthesis)); | |||
| } | |||
|
|
|||
| // BC for Symfony 2.4 and lower were elements were adding in a fake _root parent | |||
| if (0 === strpos($expression, '/_root/')) { | |||
There was a problem hiding this comment.
We should add a deprecation warning for this in 2.8 first
2a2fdeb to
b848fe7
Compare
| 'choices' => array(), | ||
| 'choices_as_values' => false, | ||
| 'choices_as_values' => true, |
There was a problem hiding this comment.
Comment from @stof: this option should be deprecated saying it has no effect anymore (and the value should be true to reflect the behavior of the code). The option should be kept though, to allow writing code compatible with 2.8 and 3.0 (passing the value explicitly).
4bbbf25 to
07c92a9
Compare
07c92a9 to
c7c0680
Compare
|
@stof would you like to take over this PR? I'm not conformable enough with the code there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks all the places where I found something that may be removed.
Please anyone, take inspiration from this patch and make it in your own PR.
I'll keep rebasing this one until it's empty.