8000 [Console] Add additional ways to detect OS400 platform by johnkary · Pull Request #16095 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add additional ways to detect OS400 platform #16095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] Add additional ways to detect OS400 platform #16095

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5130ff7
Revert "use PHP_OS instead of php_uname('s')"
johnkary Oct 3, 2015
e397379
[Console] Allow checking for OS400 platform when php_uname() disabled
johnkary Oct 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert "use PHP_OS instead of php_uname('s')" 
This reverts commit 40e0dc8.

This commit led to a regression on the OS400 platform, where the
constant PHP_OS returns "AIX" not "OS400".
  • Loading branch information
@johnkary
johnkary committed Oct 3, 2015
commit 5130ff713bc0c232da280a568962db41bd906bf3
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Output/ConsoleOutput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ protected function hasStderrSupport()
*/
private function isRunningOS400()
{
return 'OS400' === PHP_OS;
return 'OS400' === php_uname('s');
}

/**
Expand Down
0