[Form] Forward Form::submit(Request) to Form::HandleRequest #16088
Conversation
…eRequest When the argument of Form::submit is a Request object it forwards to Form::HandleRequest. Fixes the issue with uploaded files exceeding post_max_size, and form marked valid with empty fields.
|
|
|
I think the actual problem is that #11924 fixed the request handlers, but did not fix the legacy appraoch using the https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Form/Extension/HttpFoundation/EventListener/BindRequestListener.php |
| @@ -507,6 +508,10 @@ public function handleRequest($request = null) | |||
| */ | |||
| public function submit($submittedData, $clearMissing = true) | |||
| { | |||
| if ($submittedData instanceof Request) { | |||
| return $this->handleRequest($submittedData); | |||
There was a problem hiding this comment.
this should be moved after the throw new AlreadySubmittedException
There was a problem hiding this comment.
also you need to skip the following code in this case because the request handler itself also calls submit. see https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php#L116
so otherwise the form would be submitted twice and an AlreadySubmittedException is thrown.
have you actually tried to use the fix for your issue? it cannot work in its current form AFAIK.
There was a problem hiding this comment.
It shouldn't throw the AlreadySubmittedException, because it follows a different execution path inside submit()
1 Form::submit(Request)
1.1 Form::handleRequest(Request)
1.1.1 HttpFoundationRequestHandler::handleRequest(Form, Request)
1.1.1.1 Form::submit(data)
only at: 1.1.1.1 Form::submitted = true
And if we used bind
preBindEvent dispatches (does not submit, so submitted is still false)
bind will call Form::submit(Request) which will follow the same execution path above.
There was a problem hiding this comment.
ah there is a return in front of handleRequest. I didn't see that and this is what I thought is missing.
|
@Tobion Does it get a +1 from you? |
|
Hm I see one problem. When using So I think the only non-breaking solution is to fix the https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Form/Extension/HttpFoundation/EventListener/BindRequestListener.php according to https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php. |
|
But then again, this approach is deprecated anyway. So I'm not sure it's really worth to do it. |
When the argument of Form::submit is a Request object it forwards to Form::HandleRequest.
Fixes the issue with uploaded files exceeding post_max_size,
and form marked as valid with empty fields.